netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1 01/15] ice: make fwlog functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986D04FF95EA3F7D9D095CBE55CA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Tue, 22 Jul 2025 11:58:38 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "dawid.osuchowski@...ux.intel.com"
	<dawid.osuchowski@...ux.intel.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1 01/15] ice: make fwlog
 functions static



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Michal Swiatkowski
> Sent: Tuesday, July 22, 2025 12:46 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; dawid.osuchowski@...ux.intel.com;
> Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1 01/15] ice: make fwlog
> functions static
> 
> ice_fwlog_supported(), ice_fwlog_get() and ice_fwlog_supported()
> aren't called outside the ice_fwlog.c file. Make it static and move in
> the file to allow clean build.
> 
> Drop ice_fwlog_get(). It is called only from ice_fwlog_init() function
> where the fwlog support is already checked. There is no need to check
> it again, call ice_aq_fwlog_get() instead.
> 
> Drop no longer valid comment from ice_fwlog_get_supported().
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_fwlog.c | 232 ++++++++++----------
> -
>  drivers/net/ethernet/intel/ice/ice_fwlog.h |   5 +-
>  2 files changed, 109 insertions(+), 128 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_fwlog.c
> b/drivers/net/ethernet/intel/ice/ice_fwlog.c
> index a31bb026ad34..e48856206648 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fwlog.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fwlog.c
> @@ -123,6 +123,113 @@ void ice_fwlog_realloc_rings(struct ice_hw *hw,
> int index)
>  	hw->fwlog_ring.tail = 0;
>  }
>