netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1 02/15] ice: move get_fwlog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986DF9CBA9DD7D092D11D14E55CA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Tue, 22 Jul 2025 12:02:52 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "dawid.osuchowski@...ux.intel.com"
	<dawid.osuchowski@...ux.intel.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1 02/15] ice: move
 get_fwlog_data() to fwlog file



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Michal Swiatkowski
> Sent: Tuesday, July 22, 2025 12:46 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; dawid.osuchowski@...ux.intel.com;
> Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1 02/15] ice: move
> get_fwlog_data() to fwlog file
> 
> Change the function prototype to receive hw structure instead of pf to
> simplify the call. Instead of passing whole event pass only msg_buf
> pointer and length.
> 
> Make ice_fwlog_ring_full() static as it isn't  called from any other
> context.
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_fwlog.c | 27 +++++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_fwlog.h |  2 +-
> drivers/net/ethernet/intel/ice/ice_main.c  | 29 ++--------------------
>  3 files changed, 29 insertions(+), 29 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_fwlog.c
> b/drivers/net/ethernet/intel/ice/ice_fwlog.c
> index e48856206648..ea5d6d2d3f30 100644
> --- a/drivers/net/ethernet/intel/ice/ice_fwlog.c
> +++ b/drivers/net/ethernet/intel/ice/ice_fwlog.c
> @@ -6,7 +6,7 @@
>  #include "ice_common.h"
>  #include "ice_fwlog.h"
> 
> -bool ice_fwlog_ring_full(struct ice_fwlog_ring *rings)
> +static bool ice_fwlog_ring_full(struct ice_fwlog_ring *rings)
>  {
>  	u16 head, tail;
> 
Can you consider adding kernel-doc for ice_fwlog_ring_full()?