netdev - Re: [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aH8Ek6XA_EFr_XWh@calendula>
Date: Tue, 22 Jul 2025 05:25:07 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: WangYuli <wangyuli@...ontech.com>
Cc: horms@...ge.net.au, ja@....bg, kadlec@...filter.org,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, linux-kernel@...r.kernel.org,
	zhanjun@...ontech.com, niecheng1@...ontech.com,
	guanwentao@...ontech.com, wangyuli@...pin.org
Subject: Re: [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del_timer in
 comment

On Fri, Jul 04, 2025 at 04:35:53PM +0800, WangYuli wrote:
> Commit 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
> switched del_timer to timer_delete, but did not modify the comment for
> ip_vs_conn_expire_now(). Now fix it.

$ git grep del_timer net/netfilter/
net/netfilter/ipvs/ip_vs_lblc.c: *     Julian Anastasov        :    replaced del_timer call with del_timer_sync
net/netfilter/ipvs/ip_vs_lblc.c: *                                   handler and del_timer thread in SMP

Wider search, in the net tree:

net/ipv4/igmp.c: *                                      which caused a "del_timer() called
net/ipv4/igmp.c: *              Christian Daudt :       removed del_timer from

Maybe these are only for historical purpose, so leaving them untouched
is fine.