netdev - Re: [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4DFD87AA0CE5EA72+aebc5df6-9174-4ecf-9dc9-3abb312defc1@uniontech.com>
Date: Tue, 22 Jul 2025 16:05:26 +0800
From: WangYuli <wangyuli@...ontech.com>
To: Pablo Neira Ayuso <pablo@...filter.org>
Cc: horms@...ge.net.au, ja@....bg, kadlec@...filter.org, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org, lvs-devel@...r.kernel.org,
 netfilter-devel@...r.kernel.org, coreteam@...filter.org,
 linux-kernel@...r.kernel.org, zhanjun@...ontech.com,
 niecheng1@...ontech.com, guanwentao@...ontech.com, wangyuli@...pin.org
Subject: Re: [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del_timer in
 comment

Hi Pablo Neira Ayuso,

On 2025/7/22 11:25, Pablo Neira Ayuso wrote:
> On Fri, Jul 04, 2025 at 04:35:53PM +0800, WangYuli wrote:
>> Commit 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
>> switched del_timer to timer_delete, but did not modify the comment for
>> ip_vs_conn_expire_now(). Now fix it.
> $ git grep del_timer net/netfilter/
> net/netfilter/ipvs/ip_vs_lblc.c: *     Julian Anastasov        :    replaced del_timer call with del_timer_sync
> net/netfilter/ipvs/ip_vs_lblc.c: *                                   handler and del_timer thread in SMP
>
> Wider search, in the net tree:
>
> net/ipv4/igmp.c: *                                      which caused a "del_timer() called
> net/ipv4/igmp.c: *              Christian Daudt :       removed del_timer from
>
> Maybe these are only for historical purpose, so leaving them untouched
> is fine.
>
I intentionally modified only this part, leaving the other places you 
found untouched.

My goal was to update only the comment for this code block, not the 
file's changelog.


Thanks,

-- 
WangYuli

Download attachment "OpenPGP_0xC5DA1F3046F40BEE.asc" of type "application/pgp-keys" (633 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)