netdev - Re: [PATCH net-next v2 3/4] eth: bnxt: support RSS on IPv6 Flow Label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLi=EdZ1zisGZHZYQzqttQZx+8-vnoq5==mD98Tv80d1qxA@mail.gmail.com>
Date: Tue, 22 Jul 2025 00:57:14 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	donald.hunter@...il.com, pavan.chebbi@...adcom.com, gal@...dia.com, 
	andrew@...n.ch, willemdebruijn.kernel@...il.com
Subject: Re: [PATCH net-next v2 3/4] eth: bnxt: support RSS on IPv6 Flow Label

On Mon, Jul 21, 2025 at 6:49 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> It appears that the bnxt FW API has the relevant bit for Flow Label
> hashing. Plumb in the support. Obey the capability bit.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---

> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> index 1b37612b1c01..4b7213908b76 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
> @@ -1582,9 +1582,14 @@ static u64 get_ethtool_ipv4_rss(struct bnxt *bp)
>
>  static u64 get_ethtool_ipv6_rss(struct bnxt *bp)
>  {
> +       u64 rss = 0;
> +
>         if (bp->rss_hash_cfg & VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6)
> -               return RXH_IP_SRC | RXH_IP_DST;
> -       return 0;
> +               rss |= RXH_IP_SRC | RXH_IP_DST;

This flag means 2-tuple so we should:

return RXH_IP_SRC | RXH_IP_DST;

> +       if (bp->rss_hash_cfg & VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6_FLOW_LABEL)
> +               rss |= RXH_IP6_FL;

This flag means 3-tuple so we should:

return RXP_IP_SRC | RXH_IP_DST | RXH_IP6_FL;

Both of these flags cannot be set at the same time.  It can only be in
2-tuple or 3-tuple mode (see more below).

> +
> +       return rss;
>  }
>
>  static int bnxt_get_rxfh_fields(struct net_device *dev,
> @@ -1662,13 +1667,18 @@ static int bnxt_set_rxfh_fields(struct net_device *dev,
>
>         if (cmd->data == RXH_4TUPLE)
>                 tuple = 4;
> -       else if (cmd->data == RXH_2TUPLE)
> +       else if (cmd->data == RXH_2TUPLE ||
> +                cmd->data == (RXH_2TUPLE | RXH_IP6_FL))
>                 tuple = 2;
>         else if (!cmd->data)
>                 tuple = 0;
>         else
>                 return -EINVAL;
>
> +       if (cmd->data & RXH_IP6_FL &&
> +           !(bp->rss_cap & BNXT_RSS_CAP_IPV6_FLOW_LABEL_RSS_CAP))
> +               return -EINVAL;
> +
>         if (cmd->flow_type == TCP_V4_FLOW) {
>                 rss_hash_cfg &= ~VNIC_RSS_CFG_REQ_HASH_TYPE_TCP_IPV4;
>                 if (tuple == 4)
> @@ -1736,6 +1746,13 @@ static int bnxt_set_rxfh_fields(struct net_device *dev,
>                         rss_hash_cfg |= VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6;
>                 else if (!tuple)
>                         rss_hash_cfg &= ~VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6;
> +
> +               if (cmd->data & RXH_IP6_FL)
> +                       rss_hash_cfg |=
> +                               VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6_FLOW_LABEL;
> +               else
> +                       rss_hash_cfg &=
> +                               ~VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6_FLOW_LABEL;

Here, it needs to be something like this so that we only set the flag
for 2-tuple or 3-tuple.  The FW call will fail if both flags are set:

if (!tuple || tuple == 2)
        rss_hash_cfg &= ~VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6;
if (tuple == 2) {
        if (cmd->data & RXH_IP6_FL)
                rss_hash_cfg |=
                        VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6_FLOW_LABEL;
        else
                rss_hash_cfg |= VNIC_RSS_CFG_REQ_HASH_TYPE_IPV6;
}

We'll do more testing tomorrow.  Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4196 bytes)