netdev - Re: [PATCH net-next v2 4/4] selftests: drv-net: add test for RSS on flow label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6880e8674626d_334c6729439@willemb.c.googlers.com.notmuch>
Date: Wed, 23 Jul 2025 09:49:27 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 davem@...emloft.net
Cc: netdev@...r.kernel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 andrew+netdev@...n.ch, 
 horms@...nel.org, 
 donald.hunter@...il.com, 
 michael.chan@...adcom.com, 
 pavan.chebbi@...adcom.com, 
 gal@...dia.com, 
 andrew@...n.ch, 
 willemdebruijn.kernel@...il.com, 
 Jakub Kicinski <kuba@...nel.org>, 
 shuah@...nel.org, 
 sdf@...ichev.me, 
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v2 4/4] selftests: drv-net: add test for RSS on
 flow label

Jakub Kicinski wrote:
> Add a simple test for checking that RSS on flow label works,
> and that its rejected for IPv4 flows.
> 
>  # ./tools/testing/selftests/drivers/net/hw/rss_flow_label.py
>  TAP version 13
>  1..2
>  ok 1 rss_flow_label.test_rss_flow_label
>  ok 2 rss_flow_label.test_rss_flow_label_6only
>  # Totals: pass:2 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

RFS/RPS could mess with the SO_INCOMING_CPU reports if enabled.
Maybe check cfg.ifname rx-0 that they are disabled?