netdev - Re: [PATCH net-next v11 2/5] net: ti: prueth: Adds ICSSM Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250722184749.0c04d669@kernel.org>
Date: Tue, 22 Jul 2025 18:47:49 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Parvathi Pudi <parvathi@...thit.com>
Cc: danishanwar@...com, rogerq@...nel.org, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 ssantosh@...nel.org, richardcochran@...il.com, s.hauer@...gutronix.de,
 m-karicheri2@...com, glaroque@...libre.com, afd@...com,
 saikrishnag@...vell.com, m-malladi@...com, jacob.e.keller@...el.com,
 kory.maincent@...tlin.com, diogo.ivo@...mens.com,
 javier.carrasco.cruz@...il.com, horms@...nel.org, s-anna@...com,
 basharath@...thit.com, linux-arm-kernel@...ts.infradead.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, vadim.fedorenko@...ux.dev, pratheesh@...com,
 prajith@...com, vigneshr@...com, praneeth@...com, srk@...com,
 rogerq@...com, krishna@...thit.com, pmohan@...thit.com, mohan@...thit.com
Subject: Re: [PATCH net-next v11 2/5] net: ti: prueth: Adds ICSSM Ethernet
 driver

On Tue, 22 Jul 2025 18:55:02 +0530 Parvathi Pudi wrote:
> +	for_each_child_of_node(eth_ports_node, eth_node) {
> +		u32 reg;
> +
> +		if (strcmp(eth_node->name, "ethernet-port"))
> +			continue;
> +		ret = of_property_read_u32(eth_node, "reg", &reg);
> +		if (ret < 0) {
> +			dev_err(dev, "%pOF error reading port_id %d\n",
> +				eth_node, ret);
> +			return ret;

missing put for eth_node

> +		}
> +
> +		of_node_get(eth_node);
> +
> +		if (reg == 0 && !eth0_node) {
> +			eth0_node = eth_node;
> +			if (!of_device_is_available(eth0_node)) {
> +				of_node_put(eth0_node);
> +				eth0_node = NULL;
> +			}
> +		} else if (reg == 1 && !eth1_node) {
> +			eth1_node = eth_node;
> +			if (!of_device_is_available(eth1_node)) {
> +				of_node_put(eth1_node);
> +				eth1_node = NULL;
> +			}
> +		} else {
> +			if (reg == 0 || reg == 1)
> +				dev_err(dev, "duplicate port reg value: %d\n",
> +					reg);
> +			else
> +				dev_err(dev, "invalid port reg value: %d\n",
> +					reg);
> +
> +			of_node_put(eth_node);
> +		}
> +	}
-- 
pw-bot: cr