netdev - Re: [PATCH net-next v11 2/5] net: ti: prueth: Adds ICSSM Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46fb997f-ba83-44af-aad3-c8406fc7cbea@web.de>
Date: Tue, 22 Jul 2025 17:36:50 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: "Andrew F. Davis" <afd@...com>,
 Basharath Hussain Khaja <basharath@...thit.com>,
 Parvathi Pudi <parvathi@...thit.com>, Roger Quadros <rogerq@...com>,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Andrew Lunn <andrew+netdev@...n.ch>,
 Conor Dooley <conor+dt@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Diogo Ivo <diogo.ivo@...mens.com>, Eric Dumazet <edumazet@...gle.com>,
 Guillaume La Roque <glaroque@...libre.com>,
 Jacob Keller <jacob.e.keller@...el.com>, Jakub Kicinski <kuba@...nel.org>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Kory Maincent <kory.maincent@...tlin.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 MD Danish Anwar <danishanwar@...com>, Meghana Malladi <m-malladi@...com>,
 Murali Karicheri <m-karicheri2@...com>, Paolo Abeni <pabeni@...hat.com>,
 Richard Cochran <richardcochran@...il.com>, Rob Herring <robh@...nel.org>,
 Sai Krishna <saikrishnag@...vell.com>,
 Santosh Shilimkar <ssantosh@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Simon Horman <horms@...nel.org>,
 Suman Anna <s-anna@...com>
Cc: LKML <linux-kernel@...r.kernel.org>, krishna@...thit.com,
 mohan@...thit.com, pmohan@...thit.com, prajith@...com,
 Praneeth Bajjuri <praneeth@...com>, Pratheesh Gangadhar <pratheesh@...com>,
 Sriramakrishnan <srk@...com>, Roger Quadros <rogerq@...nel.org>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH net-next v11 2/5] net: ti: prueth: Adds ICSSM Ethernet
 driver

…
> +++ b/drivers/net/ethernet/ti/icssm/icssm_prueth.c
> @@ -0,0 +1,609 @@
…
> +static int icssm_prueth_probe(struct platform_device *pdev)
> +{
…
> +	/* register the network devices */
> +	if (eth0_node) {
…
> +	}
> +
> +	if (eth1_node) {
…
> +	}
> +
> +	if (eth1_node)
> +		of_node_put(eth1_node);
> +	if (eth0_node)
> +		of_node_put(eth0_node);
> +	return 0;
…

I suggest to avoid duplicate condition checks for such a function implementation.
Can any code be reused from another function?

Regards,
Markus