netdev - Re: [PATCH net-next v5.0 16/19] net/mlx5e: Configure PSP Rx flow steering rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250724133747.GN1150792@horms.kernel.org>
Date: Thu, 24 Jul 2025 14:37:47 +0100
From: Simon Horman <horms@...nel.org>
To: Daniel Zahka <daniel.zahka@...il.com>
Cc: Donald Hunter <donald.hunter@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Saeed Mahameed <saeedm@...dia.com>,
	Leon Romanovsky <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>,
	Boris Pismenny <borisp@...dia.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	Willem de Bruijn <willemb@...gle.com>,
	David Ahern <dsahern@...nel.org>,
	Neal Cardwell <ncardwell@...gle.com>,
	Patrisious Haddad <phaddad@...dia.com>,
	Raed Salem <raeds@...dia.com>, Jianbo Liu <jianbol@...dia.com>,
	Dragos Tatulea <dtatulea@...dia.com>,
	Rahul Rameshbabu <rrameshbabu@...dia.com>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Toke Høiland-Jørgensen <toke@...hat.com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5.0 16/19] net/mlx5e: Configure PSP Rx flow
 steering rules

On Wed, Jul 23, 2025 at 01:34:47PM -0700, Daniel Zahka wrote:

...

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_fs.c

...

> +int mlx5_accel_psp_fs_init_rx_tables(struct mlx5e_priv *priv)
> +{
> +	enum accel_fs_psp_type i;
> +	struct mlx5e_psp_fs *fs;
> +	int err;
> +
> +	if (!priv->psp)
> +		return 0;
> +
> +	fs = priv->psp->fs;
> +	for (i = 0; i < ACCEL_FS_PSP_NUM_TYPES; i++) {
> +		err = accel_psp_fs_rx_ft_get(fs, i);
> +		if (err)
> +			goto out_err;
> +	}
>  
> -	fs->rx_fs = accel_psp;
>  	return 0;
> +
> +out_err:
> +	i--;
> +	while (i >= 0) {

In practice i may be unsigned.
And if so this condition will always be true.

Flagged by Smatch.

> +		accel_psp_fs_rx_ft_put(fs, i);
> +		--i;
> +	}
> +
> +	return err;
>  }

...