netdev - Re: [PATCH net-next v3 1/3] net: wangxun: change the default ITR setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250725173053.2145123f@kernel.org>
Date: Fri, 25 Jul 2025 17:30:53 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jacob Keller
 <jacob.e.keller@...el.com>, Mengyuan Lou <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next v3 1/3] net: wangxun: change the default ITR
 setting

On Thu, 24 Jul 2025 16:05:46 +0800 Jiawen Wu wrote:
> Change the default RX/TX ITR for wx_mac_em devices from 20K to 7K, which
> is an experience value from out-of-tree ngbe driver, to get higher
> performance on various platforms.

"out-of-tree driver does it" + "higher performance on various platforms"
doesn't sound much in terms of justification. Shouldn't be too hard to
run a TCP_STREAM and TCP_RR tests and add the result to the commit msg..

> And cleanup the code for the next patches.

Should be a separate patch