netdev - Re: [PATCH net-next v3 2/3] net: wangxun: limit tx_max_coalesced_frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250725173158.7d372bb4@kernel.org>
Date: Fri, 25 Jul 2025 17:31:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jacob Keller
 <jacob.e.keller@...el.com>, Mengyuan Lou <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next v3 2/3] net: wangxun: limit
 tx_max_coalesced_frames_irq

On Thu, 24 Jul 2025 16:05:47 +0800 Jiawen Wu wrote:
> Add limitation on tx_max_coalesced_frames_irq as 0 ~ 65535, because
> 'wx->tx_work_limit' is declared as a member of type u16.

okay if that's the case then..

> -	if (ec->tx_max_coalesced_frames_irq)
> -		wx->tx_work_limit = ec->tx_max_coalesced_frames_irq;
> +	if (ec->tx_max_coalesced_frames_irq > WX_MAX_TX_WORK ||

	if (ec->tx_max_coalesced_frames_irq > U16_MAX ||

? why create a new define if the boundary is basically dictated 
by type width?