netdev - Re: [linux-next:master] [selftest] 236156d80d: kernel-selftests.drivers/net/netdevsim.devlink.sh.rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIbUkbxK+urvmg8+@xsang-OptiPlex-9020>
Date: Mon, 28 Jul 2025 09:38:25 +0800
From: Oliver Sang <oliver.sang@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Carolina Jubran <cjubran@...dia.com>, <oe-lkp@...ts.linux.dev>,
	<lkp@...el.com>, Cosmin Ratiu <cratiu@...dia.com>, Tariq Toukan
	<tariqt@...dia.com>, Mark Bloch <mbloch@...dia.com>,
	<netdev@...r.kernel.org>, <oliver.sang@...el.com>
Subject: Re: [linux-next:master] [selftest]  236156d80d:
 kernel-selftests.drivers/net/netdevsim.devlink.sh.rate_test.fail

hi, Jakub Kicinski,

On Fri, Jul 25, 2025 at 08:08:18AM -0700, Jakub Kicinski wrote:
> On Fri, 25 Jul 2025 20:34:58 +0800 kernel test robot wrote:
> > kernel test robot noticed "kernel-selftests.drivers/net/netdevsim.devlink.sh.rate_test.fail" on:
> > 
> > commit: 236156d80d5efd942fc395a078d6ec6d810c2c40 ("selftest: netdevsim: Add devlink rate tc-bw test")
> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master
> > 
> > [test failed on linux-next/master 97987520025658f30bb787a99ffbd9bbff9ffc9d]
> 
> This is not helpful, you have old tools in your environment.

thanks a lot for information! any special tools need to be upgraded for the
new test by this commit? we will update our environment.

> 
> Ideally you'd report regressions in existing test _cases_ 
> (I mean an individial [ OK ] turning into a [FAIL]).

yeah, we are confused by below,

from parent:

# TEST: dummy reporter test                                           [ OK ]
# TEST: rate test                                                     [ OK ]   <-----
ok 1 selftests: drivers/net/netdevsim: devlink.sh


but by this commit:

# TEST: dummy reporter test                                           [ OK ]
# Unknown option "tc-bw"
# Unknown option "tc-bw"
# Unknown option "tc-bw"
# Unknown option "tc-bw"
# Unknown option "tc-bw"
# TEST: rate test                                                     [FAIL]   <-----
# 	Unexpected tc-bw value for tc6: 0 != 60
not ok 1 selftests: drivers/net/netdevsim: devlink.sh # exit=1



> 
> The bash tests depend on too many CLI tools to be expected
> to pass. Having to detect the tool versions is an unnecessary
> burden on the test author. Tools usually get updated within
> 3 months and then all these checks become dead code for the
> rest of time...
> 

got it, we will try to study how keep our env up-to-date.