netdev - Re: [PATCH net-next v2 4/4] net: phy: micrel: Add support for lan8842

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250728064829.wdcatrtypgb6ihcp@DEN-DL-M31836.microchip.com>
Date: Mon, 28 Jul 2025 08:48:29 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: ALOK TIWARI <alok.a.tiwari@...cle.com>
CC: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <richardcochran@...il.com>, <o.rempel@...gutronix.de>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 4/4] net: phy: micrel: Add support for lan8842

The 07/26/2025 17:23, ALOK TIWARI wrote:

Hi Alok,

> 
> On 7/25/2025 1:38 AM, Horatiu Vultur wrote:
> > +static void lan8842_get_phy_stats(struct phy_device *phydev,
> > +                               struct ethtool_eth_phy_stats *eth_stats,
> > +                               struct ethtool_phy_stats *stats)
> > +{
> > +     struct lan8842_priv *priv = phydev->priv;
> > +
> > +     stats->rx_packets = priv->phy_stats.rx_packets;
> > +     stats->rx_errors = priv->phy_stats.rx_errors;
> > +     stats->tx_packets = priv->phy_stats.tx_packets;
> > +     stats->tx_errors = priv->phy_stats.rx_errors;
> 
> looks like a copy-paste mistake
> stats->tx_errors = priv->phy_stats.tx_errors;

That is a good catch!
I will fix it in the next version.

> 
> > +}
> > +
> 
> 
> Thanks,
> Alok

-- 
/Horatiu