[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250730172137.1322351-1-kuba@kernel.org>
Date: Wed, 30 Jul 2025 10:21:37 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: davem@...emloft.net
Cc: netdev@...r.kernel.org,
edumazet@...gle.com,
pabeni@...hat.com,
andrew+netdev@...n.ch,
horms@...nel.org,
Jakub Kicinski <kuba@...nel.org>,
Duo Yi <duo@...a.com>,
andrew@...n.ch,
donald.hunter@...il.com,
kory.maincent@...tlin.com,
sdf@...ichev.me
Subject: [PATCH net] netlink: specs: ethtool: fix module EEPROM input/output arguments
Module (SFP) eeprom GET has a lot of input params, they are all
mistakenly listed as output in the spec. Looks like kernel doesn't
output them at all. Correct what are the inputs and what the outputs.
Reported-by: Duo Yi <duo@...a.com>
Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
Signed-off-by: Jakub Kicinski <kuba@...nel.org>
---
CC: andrew@...n.ch
CC: donald.hunter@...il.com
CC: kory.maincent@...tlin.com
CC: sdf@...ichev.me
---
Documentation/netlink/specs/ethtool.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 1063d5d32fea..1bc1bd7d33c2 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -2342,9 +2342,6 @@ c-version-name: ethtool-genl-version
do: &module-eeprom-get-op
request:
- attributes:
- - header
- reply:
attributes:
- header
- offset
@@ -2352,6 +2349,9 @@ c-version-name: ethtool-genl-version
- page
- bank
- i2c-address
+ reply:
+ attributes:
+ - header
- data
dump: *module-eeprom-get-op
-
--
2.50.1
Powered by blists - more mailing lists