netdev - Re: [PATCH net] netlink: specs: ethtool: fix module EEPROM input/output arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIqRYhDPduCdGQjB@mini-arch>
Date: Wed, 30 Jul 2025 14:40:50 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	Duo Yi <duo@...a.com>, andrew@...n.ch, donald.hunter@...il.com,
	kory.maincent@...tlin.com, sdf@...ichev.me
Subject: Re: [PATCH net] netlink: specs: ethtool: fix module EEPROM
 input/output arguments

On 07/30, Jakub Kicinski wrote:
> Module (SFP) eeprom GET has a lot of input params, they are all
> mistakenly listed as output in the spec. Looks like kernel doesn't
> output them at all. Correct what are the inputs and what the outputs.
> 
> Reported-by: Duo Yi <duo@...a.com>
> Fixes: a353318ebf24 ("tools: ynl: populate most of the ethtool spec")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Stanislav Fomichev <sdf@...ichev.me>

(seems to match what eeprom_parse_request and eeprom_fill_reply are
doing)