netdev - Re: [PATCH net v3] net/sched: mqprio: fix stack out-of-bounds write in tc entry parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250804103550.4mbdb6b4zq3hb5j3@skbuf>
Date: Mon, 4 Aug 2025 13:35:50 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	Maher Azzouzi <maherazz04@...il.com>, jhs@...atatu.com,
	xiyou.wangcong@...il.com, jiri@...nulli.us, fejes@....elte.hu
Subject: Re: [PATCH net v3] net/sched: mqprio: fix stack out-of-bounds write
 in tc entry parsing

On Fri, Aug 01, 2025 at 05:18:57PM -0700, Jakub Kicinski wrote:
> From: Maher Azzouzi <maherazz04@...il.com>
> 
> TCA_MQPRIO_TC_ENTRY_INDEX is validated using
> NLA_POLICY_MAX(NLA_U32, TC_QOPT_MAX_QUEUE), which allows the value
> TC_QOPT_MAX_QUEUE (16). This leads to a 4-byte out-of-bounds stack
> write in the fp[] array, which only has room for 16 elements (0â€“15).
> 
> Fix this by changing the policy to allow only up to TC_QOPT_MAX_QUEUE - 1.
> 
> Fixes: f62af20bed2d ("net/sched: mqprio: allow per-TC user input of FP adminStatus")
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Maher Azzouzi <maherazz04@...il.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v3: repost for Maher, email problems..
> v2: https://lore.kernel.org/CAFQ-Uc-5ucm+Dyt2s4vV5AyJKjamF=7E_wCWFROYubR5E1PMUg@mail.gmail.com
> v2: https://lore.kernel.org/CANn89iJNKR8uBNrRCdqs-M6RspvgSK9+vxzfvXe3xUvDT538Lw@mail.gmail.com
> v1: https://lore.kernel.org/20250722155121.440969-1-maherazz04@gmail.com

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>