netdev - Re: [PATCH net-next] netfilter: clean up returns in nf_conntrack_log_invalid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <db583c33-3726-487c-a58f-d57f9a7c5b9c@linux.dev>
Date: Mon, 4 Aug 2025 18:43:16 +0800
From: Lance Yang <lance.yang@...ux.dev>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Pablo Neira Ayuso <pablo@...filter.org>
Cc: Jozsef Kadlecsik <kadlec@...filter.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, netfilter-devel@...r.kernel.org,
 coreteam@...filter.org, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] netfilter: clean up returns in
 nf_conntrack_log_invalid_sysctl()

On 2025/8/4 18:35, Dan Carpenter wrote:
> Smatch complains that these look like error paths with missing error
> codes, especially the one where we return if nf_log_is_registered() is
> true:
> 
>      net/netfilter/nf_conntrack_standalone.c:575 nf_conntrack_log_invalid_sysctl()
>      warn: missing error code? 'ret'
> 
> In fact, all these return zero deliberately.  Change them to return a
> literal instead which helps readability as well as silencing the warning.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

LGTM, feel free to add:

Acked-by: Lance Yang <lance.yang@...ux.dev>

> ---
>   net/netfilter/nf_conntrack_standalone.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c
> index 9b8b10a85233..1f14ef0436c6 100644
> --- a/net/netfilter/nf_conntrack_standalone.c
> +++ b/net/netfilter/nf_conntrack_standalone.c
> @@ -567,16 +567,16 @@ nf_conntrack_log_invalid_sysctl(const struct ctl_table *table, int write,
>   		return ret;
>   
>   	if (*(u8 *)table->data == 0)
> -		return ret;
> +		return 0;
>   
>   	/* Load nf_log_syslog only if no logger is currently registered */
>   	for (i = 0; i < NFPROTO_NUMPROTO; i++) {
>   		if (nf_log_is_registered(i))
> -			return ret;
> +			return 0;
>   	}
>   	request_module("%s", "nf_log_syslog");
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static struct ctl_table_header *nf_ct_netfilter_header;