netdev - Re: [PATCH net-next 1/3] pds_core: add simple AER handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJIcyjyGxlKm382t@wunner.de>
Date: Tue, 5 Aug 2025 17:01:30 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Shannon Nelson <shannon.nelson@....com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	edumazet@...gle.com, pabeni@...hat.com, brett.creeley@....com,
	drivers@...sando.io
Subject: Re: [PATCH net-next 1/3] pds_core: add simple AER handler

On Fri, Feb 16, 2024 at 02:29:50PM -0800, Shannon Nelson wrote:
> Set up the pci_error_handlers error_detected and resume to be
> useful in handling AER events.

The above was committed as d740f4be7cf0 ("pds_core: add simple
AER handler").

Just noticed the following while inspecting the pci_error_handlers
of this driver:

> +static pci_ers_result_t pdsc_pci_error_detected(struct pci_dev *pdev,
> +						pci_channel_state_t error)
> +{
> +	if (error == pci_channel_io_frozen) {
> +		pdsc_reset_prepare(pdev);
> +		return PCI_ERS_RESULT_NEED_RESET;
> +	}
> +
> +	return PCI_ERS_RESULT_NONE;
> +}

The ->error_detected() callback of this driver invokes
pdsc_reset_prepare(), which unmaps BARs and calls pci_disable_device(),
but there is no corresponding ->slot_reset() callback which would invoke
pdsc_reset_done() to re-enable the device after reset recovery.

I don't have this hardware available for testing, hence do not feel
comfortable submitting a fix.  But this definitely looks broken.

Thanks,

Lukas