netdev - Re: [PATCH net] net: ti: icss-iep: Fix incorrect type for return value in extts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7140f850-dd56-4d97-90b9-9c85494dc1a3@lunn.ch>
Date: Tue, 5 Aug 2025 17:01:49 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: danishanwar@...com, rogerq@...nel.org, m-malladi@...com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net] net: ti: icss-iep: Fix incorrect type for return
 value in extts_enable()

On Tue, Aug 05, 2025 at 07:23:18AM -0700, Alok Tiwari wrote:
> The variable ret in icss_iep_extts_enable() was incorrectly declared
> as u32, while the function returns int and may return negative error
> codes. This will cause sign extension issues and incorrect error
> propagation. Update ret to be int to fix error handling.
> 
> This change corrects the declaration to avoid potential type mismatch.
> 
> Fixes: c1e0230eeaab ("net: ti: icss-iep: Add IEP driver")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew