netdev - Re: [RFC v1 21/22] net: parametrise mp open with a queue config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250806150535.4ce40014@kernel.org>
Date: Wed, 6 Aug 2025 15:05:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mina Almasry <almasrymina@...gle.com>
Cc: Pavel Begunkov <asml.silence@...il.com>, netdev@...r.kernel.org,
 io-uring@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, Willem de
 Bruijn <willemb@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 andrew+netdev@...n.ch, horms@...nel.org, davem@...emloft.net,
 sdf@...ichev.me, dw@...idwei.uk, michael.chan@...adcom.com,
 dtatulea@...dia.com, ap420073@...il.com
Subject: Re: [RFC v1 21/22] net: parametrise mp open with a queue config

On Wed, 6 Aug 2025 11:30:38 -0700 Mina Almasry wrote:
> Sorry, I was disagreeing. The flow above seems complicated. I'm
> probably missing something that requires this complication. I was
> suggesting an approach I find more straightforward. 
>
> Something like:
>   nedev_config = get_driver_defaults()
>   qcfg = get_driver_defaults()
> 
>   for each setting:
>     if qcfg[i].X is set:
>        use qcfg[i].X
>     else
>       use netdev_config.X

IMO the rules on when to override/update and reset qcfg[i].X will
get much more complicated than the extra `else if` in this logic.

Plus I suspect at some point we may want to add another layer here
for e.g. a group of queues delegated to the same container interface
(netkit, veth, ipvlan etc.) So I want to establish a clear model
rather than "optimize" for the number of u32 variables.

Most code (drivers) should never be exposed to any of this, they
consume a flattened qcfg for a reason.