netdev - Re: [PATCH net-next 0/3] netdevsim: Add support for ethtool stats and add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALSBQO=Q5fPxAuAAdgN8eUgTGVzdRYhthLvb6052SzsDV0uZ3A@mail.gmail.com>
Date: Wed, 6 Aug 2025 10:05:27 -0400
From: Dennis Chen <dchen27@...u.edu>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Dennis Chen <dechen@...hat.com>, netdev@...r.kernel.org, davem@...emloft.net, 
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch, 
	petrm@...dia.com
Subject: Re: [PATCH net-next 0/3] netdevsim: Add support for ethtool stats and add

On Tue, Aug 5, 2025 at 6:55 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue,  5 Aug 2025 17:33:53 -0400 Dennis Chen wrote:
> > This series adds support for querying standard interface stats and
> > driver-specific stats with ethtool -S. This allows hardware-independent
> > testing of ethtool stats reporting. Driver-specific stats are incremented
> > every 100ms once enabled through a debugfs toggle.
> >
> > Also adds a selftest for ethtool -S for netdevsim.
> >
> > The implementation of mock stats is heavily based on the mock L3 stats
> > support added by commit 1a6d7ae7d63c45("netdevsim: Introduce support for
> > L3 offload xstats").
> >
> > Note: Further replies will come from my school email address,
> > dchen27@...u.edu, as I will soon lose access to my Red Hat email.
>
> The tests for netdevsim must test something meaningful in the kernel.
> This submission really looks like you need it to test some user space
> code.
> --
> pw-bot: reject
Hi Jakub,

This test would help verify that ethtool_ops correctly propagates stats to
userspace, would that not be significant enough for a test?

My thought was that it would be similar to the patches for ethtool
--show-phys here:
https://lore.kernel.org/netdev/20250710062248.378459-1-maxime.chevallier@bootlin.com/

Thanks,

Dennis Chen