netdev - Re: [PATCH net-next 0/3] netdevsim: Add support for ethtool stats and add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250806074800.65fa46bc@kernel.org>
Date: Wed, 6 Aug 2025 07:48:00 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Dennis Chen <dchen27@...u.edu>
Cc: Dennis Chen <dechen@...hat.com>, netdev@...r.kernel.org,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, petrm@...dia.com, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next 0/3] netdevsim: Add support for ethtool stats
 and add

On Wed, 6 Aug 2025 10:05:27 -0400 Dennis Chen wrote:
> > The tests for netdevsim must test something meaningful in the kernel.
> > This submission really looks like you need it to test some user space
> > code.
> 
> This test would help verify that ethtool_ops correctly propagates stats to
> userspace, would that not be significant enough for a test?
> 
> My thought was that it would be similar to the patches for ethtool
> --show-phys here:
> https://lore.kernel.org/netdev/20250710062248.378459-1-maxime.chevallier@bootlin.com/

What are you trying to test. Like, what _actually_ made you and Kamal
write these patches? I can't think of many bugs in the area. And you
clearly have zero familiarity with our recommendation of what stats
to report and how :/ so if anything your code is hurting more than
helping.