netdev - Re: [PATCH 3/3] SUNRPC: Remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5facdb49-8ede-42c3-ba35-63b266f4e368@oracle.com>
Date: Sun, 10 Aug 2025 11:34:53 -0400
From: Chuck Lever <chuck.lever@...cle.com>
To: Qianfeng Rong <rongqianfeng@...o.com>, Jeff Layton <jlayton@...nel.org>,
        NeilBrown <neil@...wn.name>, Olga Kornievskaia <okorniev@...hat.com>,
        Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>,
        Trond Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
        "open list:KERNEL NFSD, SUNRPC, AND LOCKD SERVERS"
 <linux-nfs@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] SUNRPC: Remove redundant __GFP_NOWARN

On 8/10/25 3:29 AM, Qianfeng Rong wrote:
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
> __GFP_NOWARN.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---
>  net/sunrpc/socklib.c           | 2 +-
>  net/sunrpc/xprtrdma/rpc_rdma.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/socklib.c b/net/sunrpc/socklib.c
> index 4e92e2a50168..d8d8842c7de5 100644
> --- a/net/sunrpc/socklib.c
> +++ b/net/sunrpc/socklib.c
> @@ -86,7 +86,7 @@ xdr_partial_copy_from_skb(struct xdr_buf *xdr, struct xdr_skb_reader *desc)
>  		/* ACL likes to be lazy in allocating pages - ACLs
>  		 * are small by default but can get huge. */
>  		if ((xdr->flags & XDRBUF_SPARSE_PAGES) && *ppage == NULL) {
> -			*ppage = alloc_page(GFP_NOWAIT | __GFP_NOWARN);
> +			*ppage = alloc_page(GFP_NOWAIT);
>  			if (unlikely(*ppage == NULL)) {
>  				if (copied == 0)
>  					return -ENOMEM;
> diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c
> index 1478c41c7e9d..3aac1456e23e 100644
> --- a/net/sunrpc/xprtrdma/rpc_rdma.c
> +++ b/net/sunrpc/xprtrdma/rpc_rdma.c
> @@ -190,7 +190,7 @@ rpcrdma_alloc_sparse_pages(struct xdr_buf *buf)
>  	ppages = buf->pages + (buf->page_base >> PAGE_SHIFT);
>  	while (len > 0) {
>  		if (!*ppages)
> -			*ppages = alloc_page(GFP_NOWAIT | __GFP_NOWARN);
> +			*ppages = alloc_page(GFP_NOWAIT);
>  		if (!*ppages)
>  			return -ENOBUFS;
>  		ppages++;

Acked-by: Chuck Lever <chuck.lever@...cle.com>

-- 
Chuck Lever