netdev - Re: [PATCH 1/3] tcp: cdg: remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKFbfNvKWa=yrPnfkTdfEo-xS-9TfE6ThgZF8MATU0Cmg@mail.gmail.com>
Date: Mon, 11 Aug 2025 01:54:06 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Qianfeng Rong <rongqianfeng@...o.com>
Cc: Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...gle.com>, 
	"David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	"open list:NETWORKING [TCP]" <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] tcp: cdg: remove redundant __GFP_NOWARN

On Sun, Aug 10, 2025 at 12:30 AM Qianfeng Rong <rongqianfeng@...o.com> wrote:
>
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant
> __GFP_NOWARN.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---
>  net/ipv4/tcp_cdg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/tcp_cdg.c b/net/ipv4/tcp_cdg.c
> index ba4d98e510e0..fbad6c35dee9 100644
> --- a/net/ipv4/tcp_cdg.c
> +++ b/net/ipv4/tcp_cdg.c
> @@ -379,7 +379,7 @@ static void tcp_cdg_init(struct sock *sk)
>         /* We silently fall back to window = 1 if allocation fails. */
>         if (window > 1)
>                 ca->gradients = kcalloc(window, sizeof(ca->gradients[0]),
> -                                       GFP_NOWAIT | __GFP_NOWARN);
> +                                       GFP_NOWAIT);

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

It is unclear why GFP_NOWAIT was used here, while all other TCP
allocations use GFP_ATOMIC or GFP_KERNEL.