netdev - Re: [PATCH net] net/sched: ets: use old 'nbands' while purging unused classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81bd4809-b268-42a2-af34-03087f7ff329@mojatatu.com>
Date: Mon, 11 Aug 2025 06:53:47 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Davide Caratti <dcaratti@...hat.com>
Cc: Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang
 <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Lion Ackermann <nnamrec@...il.com>,
 Petr Machata <petrm@...lanox.com>, netdev@...r.kernel.org,
 Ivan Vecera <ivecera@...hat.com>, Li Shuang <shuali@...hat.com>
Subject: Re: [PATCH net] net/sched: ets: use old 'nbands' while purging unused
 classes

On 8/11/25 04:49, Davide Caratti wrote:
> On Fri, Aug 08, 2025 at 03:15:13PM -0300, Victor Nogueira wrote:
>> On 8/7/25 12:48, Davide Caratti wrote:
> 
> [...]
>   
>>> Fixes: 103406b38c60 ("net/sched: Always pass notifications when child class becomes empty")
>>> Fixes: c062f2a0b04d ("net/sched: sch_ets: don't remove idle classes from the round-robin list")
>>> Fixes: dcc68b4d8084 ("net: sch_ets: Add a new Qdisc")
>>> Reported-by: Li Shuang <shuali@...hat.com>
>>> Closes: https://issues.redhat.com/browse/RHEL-108026
>>> Co-developed-by: Ivan Vecera <ivecera@...hat.com>
>>> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
>>> Signed-off-by: Davide Caratti <dcaratti@...hat.com>
>>
>> Can you submit a tdc test case for this bug?
> 
> hello Victor,
> 
> Thanks for looking at this!
> 
> At a first look: TDC is not the correct tool here, because it doesn't
> allow changing the qdisc tree while the scapy plugin emits traffic.

I see.

> Maybe it's better to extend sch_ets.sh from net/forwarding instead?
> If so, I can follow-up on net-next with a patch that adds a new
> test-case that includes the 3-lines in [1] - while this patch can go
> as-is in 'net' (and eventually in stable). In alternative, I can
> investigate on TDC adding "sch_plug" to the qdisc tree in a way
> that DWRR never deplete, and the crash would then happen with "verifyCmd".
> 
> WDYT?

That works for me as well.

cheers,
Victor