netdev - Re: [PATCH net] net/sched: ets: use old 'nbands' while purging unused classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3ffa213-ba09-47ce-9b9b-5d8a4bac9d71@mojatatu.com>
Date: Mon, 11 Aug 2025 10:52:08 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Davide Caratti <dcaratti@...hat.com>
Cc: Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang
 <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Lion Ackermann <nnamrec@...il.com>,
 Petr Machata <petrm@...lanox.com>, netdev@...r.kernel.org,
 Ivan Vecera <ivecera@...hat.com>, Li Shuang <shuali@...hat.com>
Subject: Re: [PATCH net] net/sched: ets: use old 'nbands' while purging unused
 classes

On 8/11/25 06:53, Victor Nogueira wrote:
> On 8/11/25 04:49, Davide Caratti wrote:
>> Maybe it's better to extend sch_ets.sh from net/forwarding instead?
>> If so, I can follow-up on net-next with a patch that adds a new
>> test-case that includes the 3-lines in [1] - while this patch can go
>> as-is in 'net' (and eventually in stable). In alternative, I can
>> investigate on TDC adding "sch_plug" to the qdisc tree in a way
>> that DWRR never deplete, and the crash would then happen with 
>> "verifyCmd".
>>
>> WDYT?
> 
> That works for me as well.

Sorry, should've been more specific.
I meant that the net/forwarding approach you suggested
seems ok. The tdc approach would be a lot of work and
I don't believe it's worth it.

cheers,
Victor