netdev - Re: [PATCH net-next V2 1/9] eth: fbnic: Add support for HDS configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5585b91c-e836-457f-a3e1-3fe7fabe12be@gmail.com>
Date: Tue, 12 Aug 2025 06:52:49 -0700
From: Mohsin Bashir <mohsin.bashr@...il.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, netdev@...r.kernel.org
Cc: kuba@...nel.org, alexanderduyck@...com, andrew+netdev@...n.ch,
 ast@...nel.org, bpf@...r.kernel.org, corbet@....net, daniel@...earbox.net,
 davem@...emloft.net, edumazet@...gle.com, hawk@...nel.org, horms@...nel.org,
 jdamato@...tly.com, john.fastabend@...il.com, kernel-team@...a.com,
 pabeni@...hat.com, sdf@...ichev.me, aleksander.lobakin@...el.com
Subject: Re: [PATCH net-next V2 1/9] eth: fbnic: Add support for HDS
 configuration


>>       fbnic_config_drop_mode_rcq(nv, rcq);
>> +    /* Force lower bound on MAX_HEADER_BYTES. Below this, all frames 
>> should
>> +     * be split at L4. It would also result in the frames being split at
>> +     * L2/L3 depending on the frame size.
>> +     */
>> +    if (fbn->hds_thresh < FBNIC_HDR_BYTES_MIN) {
>> +        rcq_ctl = FBNIC_QUEUE_RDE_CTL0_EN_HDR_SPLIT;
>> +        hds_thresh = FBNIC_HDR_BYTES_MIN;
>> +    }
>> +
>>       rcq_ctl = FIELD_PREP(FBNIC_QUEUE_RDE_CTL1_PADLEN_MASK, 
>> FBNIC_RX_PAD) |
> 
> because you still unconditionally rewrite the value here. at the same
> time FBNIC_QUEUE_RDE_CTL0_EN_HDR_SPLIT value will be lost, so I believe
> it should be
> 
>   rcq_ctl |= FIELD_PREP(FBNIC_QUEUE_RDE_CTL1_PADLEN_MASK, FBNIC_RX_PAD) |
> 
> and then the init code above makes sense.
> 
Yes, you are right. I kinda messed up this patch in V2. Thanks for 
pointing this out.