netdev - Re: [PATCH net-next V2 1/9] eth: fbnic: Add support for HDS configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250812074148.736c6ce6@kernel.org>
Date: Tue, 12 Aug 2025 07:41:48 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, andrew+netdev@...n.ch,
 ast@...nel.org, bpf@...r.kernel.org, corbet@....net, daniel@...earbox.net,
 davem@...emloft.net, edumazet@...gle.com, hawk@...nel.org,
 horms@...nel.org, jdamato@...tly.com, john.fastabend@...il.com,
 kernel-team@...a.com, pabeni@...hat.com, sdf@...ichev.me,
 vadim.fedorenko@...ux.dev, aleksander.lobakin@...el.com
Subject: Re: [PATCH net-next V2 1/9] eth: fbnic: Add support for HDS
 configuration

On Mon, 11 Aug 2025 14:13:30 -0700 Mohsin Bashir wrote:
> Add support for configuring the header data split threshold.
> For fbnic, the tcp data split support is enabled all the time.
> 
> Fbnic supports a maximum buffer size of 4KB. However, the reservation
> for the headroom, tailroom, and padding reduce the max header size
> accordingly.

drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:2214:24: error: use of undeclared identifier 'FBNIC_HDR_BYTES_MIN'
 2214 |         if (fbn->hds_thresh < FBNIC_HDR_BYTES_MIN) {
      |                               ^

You're adding the constant in patch 5 and use it in patch 1.
-- 
pw-bot: cr