netdev - Re: [PATCH net-next 1/2] devlink/port: Check attributes early and constify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250812074657.368dc780@kernel.org>
Date: Tue, 12 Aug 2025 07:46:57 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Parav Pandit <parav@...dia.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <horms@...nel.org>, <netdev@...r.kernel.org>, <jiri@...nulli.us>, Jiri
 Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next 1/2] devlink/port: Check attributes early and
 constify

On Tue, 12 Aug 2025 06:51:05 +0300 Parav Pandit wrote:
>  void devlink_port_attrs_set(struct devlink_port *devlink_port,
> -			    struct devlink_port_attrs *devlink_port_attrs);
> +			    const struct devlink_port_attrs *dl_port_attrs);

Why not rename to attr, which is what the implementation uses?

>  void devlink_port_attrs_set(struct devlink_port *devlink_port,
> -			    struct devlink_port_attrs *attrs)
> +			    const struct devlink_port_attrs *attrs)