netdev - RE: [PATCH net-next 2/2] devlink/port: Simplify return checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CY8PR12MB7195C1ACF298C258BB37E759DC2BA@CY8PR12MB7195.namprd12.prod.outlook.com>
Date: Tue, 12 Aug 2025 13:45:09 +0000
From: Parav Pandit <parav@...dia.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"horms@...nel.org" <horms@...nel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "jiri@...nulli.us" <jiri@...nulli.us>, Jiri Pirko <jiri@...dia.com>
Subject: RE: [PATCH net-next 2/2] devlink/port: Simplify return checks



> From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
> Sent: 12 August 2025 06:30 PM
> 
> On 12/08/2025 04:51, Parav Pandit wrote:
> > Drop always returning 0 from the helper routine and simplify its
> > callers.
> 
> 
> Oh, I see, you split it into 2 patches, but I'm not sure it's actually needed,
> because the first patch doesn't look logical on its own...

I can squash the two patches to one.
The general guidance was to not do multiple different types of changes in single patch.
No strong preference to me.