netdev - RE: [PATCH net-next 1/2] devlink/port: Check attributes early and constify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CY8PR12MB7195D5CCF640C5F85EFC199EDC2BA@CY8PR12MB7195.namprd12.prod.outlook.com>
Date: Tue, 12 Aug 2025 16:20:08 +0000
From: Parav Pandit <parav@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"horms@...nel.org" <horms@...nel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "jiri@...nulli.us" <jiri@...nulli.us>, Jiri Pirko
	<jiri@...dia.com>
Subject: RE: [PATCH net-next 1/2] devlink/port: Check attributes early and
 constify



> From: Jakub Kicinski <kuba@...nel.org>
> Sent: 12 August 2025 08:17 PM
> 
> On Tue, 12 Aug 2025 06:51:05 +0300 Parav Pandit wrote:
> >  void devlink_port_attrs_set(struct devlink_port *devlink_port,
> > -			    struct devlink_port_attrs *devlink_port_attrs);
> > +			    const struct devlink_port_attrs *dl_port_attrs);
> 
> Why not rename to attr, which is what the implementation uses?
>
Make sense. Will change in v2.
 
> >  void devlink_port_attrs_set(struct devlink_port *devlink_port,
> > -			    struct devlink_port_attrs *attrs)
> > +			    const struct devlink_port_attrs *attrs)