netdev - RE: [Intel-wired-lan] [PATCH iwl-net v3 5/6] idpf: stop Tx if there are insufficient buffer resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB629732DCFC7D2DD9EB4C11239B2BA@SJ1PR11MB6297.namprd11.prod.outlook.com>
Date: Tue, 12 Aug 2025 16:45:32 +0000
From: "Salin, Samuel" <samuel.salin@...el.com>
To: "Hay, Joshua A" <joshua.a.hay@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Hay, Joshua A"
	<joshua.a.hay@...el.com>, "Chittim, Madhu" <madhu.chittim@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v3 5/6] idpf: stop Tx if there
 are insufficient buffer resources



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Joshua Hay
> Sent: Friday, July 25, 2025 11:42 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Hay, Joshua A <joshua.a.hay@...el.com>;
> Chittim, Madhu <madhu.chittim@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v3 5/6] idpf: stop Tx if there are
> insufficient buffer resources
> 
> The Tx refillq logic will cause packets to be silently dropped if there are not
> enough buffer resources available to send a packet in flow scheduling mode.
> Instead, determine how many buffers are needed along with number of
> descriptors. Make sure there are enough of both resources to send the packet,
> and stop the queue if not.
> 
> Fixes: 7292af042bcf ("idpf: fix a race in txq wakeup")
> Signed-off-by: Joshua Hay <joshua.a.hay@...el.com>
> Reviewed-by: Madhu Chittim <madhu.chittim@...el.com>
> ---
> v2:
> - Init buf_count to 1 and += nr_frags to account for header
> - s/unsigned int/u32 where appropriate
> - replaced BUFS_UNUSED macro with static inline func
> ---
> 2.39.2

Tested-by: Samuel Salin <Samuel.salin@...el.com>