netdev - RE: [Intel-wired-lan] [PATCH iwl-net v3 3/6] idpf: simplify and fix splitq Tx packet rollback error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB6297271020911282AB5F71399B2BA@SJ1PR11MB6297.namprd11.prod.outlook.com>
Date: Tue, 12 Aug 2025 16:45:29 +0000
From: "Salin, Samuel" <samuel.salin@...el.com>
To: "Hay, Joshua A" <joshua.a.hay@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Hay, Joshua A"
	<joshua.a.hay@...el.com>, "Chittim, Madhu" <madhu.chittim@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v3 3/6] idpf: simplify and fix
 splitq Tx packet rollback error path



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Joshua Hay
> Sent: Friday, July 25, 2025 11:42 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Hay, Joshua A <joshua.a.hay@...el.com>;
> Chittim, Madhu <madhu.chittim@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v3 3/6] idpf: simplify and fix splitq Tx
> packet rollback error path
> 
> Move (and rename) the existing rollback logic to singleq.c since that will be the
> only consumer. Create a simplified splitq specific rollback function to loop
> through and unmap tx_bufs based on the completion tag.
> This is critical before replacing the Tx buffer ring with the buffer pool since the
> previous rollback indexing will not work to unmap the chained buffers from
> the pool.
> 
> Cache the next_to_use index before any portion of the packet is put on the
> descriptor ring. In case of an error, the rollback will bump tail to the correct
> next_to_use value. Because the splitq path now supports different types of
> context descriptors (and potentially multiple in the future), this will take care
> of rolling back any and all context descriptors encoded on the ring for the
> erroneous packet. The previous rollback logic was broken for PTP packets since
> it would not account for the PTP context descriptor.
> 
> Fixes: 1a49cf814fe1 ("idpf: add Tx timestamp flows")
> Signed-off-by: Joshua Hay <joshua.a.hay@...el.com>
> Reviewed-by: Madhu Chittim <madhu.chittim@...el.com>
> ---
> 2.39.2

Tested-by: Samuel Salin <Samuel.salin@...el.com>