netdev - Re: [RFC net-next 08/17] net/dibs: Register ism as dibs device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aJvFlBISHJMe-0Jt@linux.alibaba.com>
Date: Wed, 13 Aug 2025 06:52:04 +0800
From: Dust Li <dust.li@...ux.alibaba.com>
To: Alexandra Winter <wintera@...ux.ibm.com>,
	David Miller <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"D. Wythe" <alibuda@...ux.alibaba.com>,
	Sidraya Jayagond <sidraya@...ux.ibm.com>,
	Wenjia Zhang <wenjia@...ux.ibm.com>,
	Julian Ruess <julianr@...ux.ibm.com>
Cc: netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Thorsten Winkler <twinkler@...ux.ibm.com>,
	Simon Horman <horms@...nel.org>,
	Mahanta Jambigi <mjambigi@...ux.ibm.com>,
	Tony Lu <tonylu@...ux.alibaba.com>,
	Wen Gu <guwen@...ux.alibaba.com>, Halil Pasic <pasic@...ux.ibm.com>,
	linux-rdma@...r.kernel.org
Subject: Re: [RFC net-next 08/17] net/dibs: Register ism as dibs device

On 2025-08-11 16:27:21, Alexandra Winter wrote:
>
>
>On 10.08.25 16:46, Dust Li wrote:
>> I've been wondering whether we should completely remove the ISM concept
>> from SMC. Including rename smc_ism.c into smc_dibs.c.
>> 
>> Since DIBS already serves as the replacement for ISM, having both ISM
>> and DIBS coexist in the codebase seems a bit confusing and inconsistent.
>> Removing ISM could help streamline the code and improve clarity.
>> 
>> Best regards,
>> Dust
>
>I second that.
>Like I wrote in the last commit message:
>"[RFC net-next 17/17] net/dibs: Move event handling to dibs layer
>...
>SMC-D and ISM are now independent.
>struct ism_dev can be moved to drivers/s390/net/ism.h.
>
>Note that in smc, the term 'ism' is still used. Future patches could
>replace that with 'dibs' or 'smc-d' as appropriate."
>
>
>I am not sure what would be the best way to do such a global replacement.
>One big patch on top of dibs-series? That would be a lot of changes without
>adding any functionality.

I prefer this approach. Renaming without changing functionality keeps
the patch clean and makes it easier to cherry-pick.

Best regards,
Dust

>Or do you have other clarity improvements in the pipeline that could be combined?
>I would like to defer that decision to the smc maintainers. Would that be ok for you?
>