netdev - Re: [RFC net-next 10/17] net/dibs: Define dibs_client_ops and dibs_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aJvHGi9O0ReoDHFo@linux.alibaba.com>
Date: Wed, 13 Aug 2025 06:58:34 +0800
From: Dust Li <dust.li@...ux.alibaba.com>
To: Alexandra Winter <wintera@...ux.ibm.com>,
	David Miller <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"D. Wythe" <alibuda@...ux.alibaba.com>,
	Sidraya Jayagond <sidraya@...ux.ibm.com>,
	Wenjia Zhang <wenjia@...ux.ibm.com>,
	Julian Ruess <julianr@...ux.ibm.com>
Cc: netdev@...r.kernel.org, linux-s390@...r.kernel.org,
	Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Thorsten Winkler <twinkler@...ux.ibm.com>,
	Simon Horman <horms@...nel.org>,
	Mahanta Jambigi <mjambigi@...ux.ibm.com>,
	Tony Lu <tonylu@...ux.alibaba.com>,
	Wen Gu <guwen@...ux.alibaba.com>, Halil Pasic <pasic@...ux.ibm.com>,
	linux-rdma@...r.kernel.org
Subject: Re: [RFC net-next 10/17] net/dibs: Define dibs_client_ops and
 dibs_dev_ops

On 2025-08-11 17:12:46, Alexandra Winter wrote:
>
>
>On 10.08.25 16:53, Dust Li wrote:
>> Hi Winter,
>> 
>> I feel a bit hard for me to review the code especially with so many
>> intermediate parts. I may need more time to review these.
>> 
>> Seperate such a big refine patch is hard. Maybe put the
>> small parts in the front and the final one in the last to reduce
>> the intermediate part as much as possible ? I'm not sure.
>> 
>> Best regards,
>> Dust
>
>I can understand that very well. I tried hard to split up the dibs layer implementation
>into consumable pieces, while preserving the functionality of smc-d, ism and loopback at
>each intermediate step, so it is always bisectable.
>
>I know this patch  "[RFC net-next 10/17] net/dibs: Define dibs_client_ops and dibs_dev_ops"
>and "[RFC net-next 16/17] net/dibs: Move data path to dibs layer" are rather large, but I
>could not find a way to split them up without temporarily breaking functionality.
>If you have any ideas, please let me know.
>
>You write:
>> Maybe put the small parts in the front and the final one in the last
>I am not sure I understand, what exactly you have in mind here. Are you asking
>for even larger patches?

Yes, that’s what I had in mind. :)
Of course, if it seems to complicate things, please disregard it.

>
>> I may need more time to review these.
>FYI: I will be on vacation the last 2 weeks of August.
>Would you rather have an RFC v2 this week with all the changes, I made so far?
>Or would you prefer that you continue reviewing this RFC and I send a new version
>in the first week of September?

No warries, both OK for me now.

Best regards,
Dust