netdev - Re: [RFC net-next v1 4/6] net: convert page pool dma helpers to netmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fad270c7-5f7f-4739-b40e-4460f96fb9af@gmail.com>
Date: Wed, 13 Aug 2025 09:34:45 +0100
From: Pavel Begunkov <asml.silence@...il.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 davem@...emloft.net, sdf@...ichev.me, dw@...idwei.uk,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>,
 Byungchul Park <byungchul@...com>
Subject: Re: [RFC net-next v1 4/6] net: convert page pool dma helpers to
 netmem_desc

On 8/13/25 01:05, Mina Almasry wrote:
...>> diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h
>> index db180626be06..a9774d582933 100644
>> --- a/include/net/page_pool/helpers.h
>> +++ b/include/net/page_pool/helpers.h
...>> +static inline dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem)
>> +{
>> +       const struct netmem_desc *desc = netmem_to_nmdesc(netmem);
>> +
>> +       return page_pool_get_dma_addr_nmdesc(desc);
>> +}
>> +
> 
> nit: this wrapper feels very unnecessary. The _nmdesc variant has only
> one call site from page_pool_get_dma_addr_netmem. I'd really prefer we
> don't have the _nmdesc variant.

It's reused for zcrx in Patch 6. If I want a cast there optimised,
it's either that, or some new get_dma_niov helper, which would still
need to be expressed through sth like page_pool_get_dma_addr_nmdesc()
to avoid duplication.

-- 
Pavel Begunkov