netdev - Re: [RFC net-next v1 6/6] io_uring/zcrx: avoid netmem casts with nmdesc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izMD2nnmBWbMp3zRuNwWjiphdwu7NFpVCvmcy0SkBLFG7Q@mail.gmail.com>
Date: Tue, 12 Aug 2025 17:16:25 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Pavel Begunkov <asml.silence@...il.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, davem@...emloft.net, 
	sdf@...ichev.me, dw@...idwei.uk, Jesper Dangaard Brouer <hawk@...nel.org>, 
	Ilias Apalodimas <ilias.apalodimas@...aro.org>, Byungchul Park <byungchul@...com>
Subject: Re: [RFC net-next v1 6/6] io_uring/zcrx: avoid netmem casts with nmdesc

On Mon, Aug 11, 2025 at 9:28 AM Pavel Begunkov <asml.silence@...il.com> wrote:
>
> There is a bunch of hot path places where zcrx casts a net_iov to a
> netmem just to pass it to a generic helper, which will immediately
> remove NET_IOV from it. It's messy, and compilers can't completely
> optimise it. Use newly introduced netmem_desc based helpers to avoid the
> overhead.
>
> Signed-off-by: Pavel Begunkov <asml.silence@...il.com>

Great cleanup actually. I didn't realize how much of a pain the casts were.

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

-- 
Thanks,
Mina