netdev - Re: [PATCH v3 net-next 02/15] dt-bindings: net: add ptp-timer property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250814-icy-intelligent-sambar-e504ec@kuoka>
Date: Thu, 14 Aug 2025 10:27:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wei Fang <wei.fang@....com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	richardcochran@...il.com, claudiu.manoil@....com, vladimir.oltean@....com, 
	xiaoning.wang@....com, andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, vadim.fedorenko@...ux.dev, Frank.Li@....com, 
	shawnguo@...nel.org, s.hauer@...gutronix.de, festevam@...il.com, fushi.peng@....com, 
	devicetree@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	imx@...ts.linux.dev, kernel@...gutronix.de
Subject: Re: [PATCH v3 net-next 02/15] dt-bindings: net: add ptp-timer
 property

On Tue, Aug 12, 2025 at 05:46:21PM +0800, Wei Fang wrote:
> Signed-off-by: Wei Fang <wei.fang@....com>
> 
> ---
> v3 changes:
> New patch, add a generic property instead of adding a property to
> fsl,enetc.yaml
> ---
>  .../devicetree/bindings/net/ethernet-controller.yaml         | 5 +++++
>  1 file changed, 5 insertions(+)

In the same patch please remove redundancies: fsl,fman-dtsec.yaml and
maybe more. That's always one logical change. Otherwise you introduce
redundant or duplicated code.

Best regards,
Krzysztof