netdev - Re: [PATCH v3 net-next 03/15] dt-bindings: net: add an example for ENETC v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250814-finicky-tall-wolverine-6a5b90@kuoka>
Date: Thu, 14 Aug 2025 10:29:45 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Wei Fang <wei.fang@....com>, "robh@...nel.org" <robh@...nel.org>, 
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, 
	"richardcochran@...il.com" <richardcochran@...il.com>, Claudiu Manoil <claudiu.manoil@....com>, 
	Vladimir Oltean <vladimir.oltean@....com>, Clark Wang <xiaoning.wang@....com>, 
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>, 
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, 
	"pabeni@...hat.com" <pabeni@...hat.com>, "vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>, 
	"shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, 
	"festevam@...il.com" <festevam@...il.com>, "F.S. Peng" <fushi.peng@....com>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>, 
	"kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH v3 net-next 03/15] dt-bindings: net: add an example for
 ENETC v4

On Wed, Aug 13, 2025 at 11:10:18AM -0400, Frank Li wrote:
> On Wed, Aug 13, 2025 at 01:38:55AM +0000, Wei Fang wrote:
> > > On Tue, Aug 12, 2025 at 05:46:22PM +0800, Wei Fang wrote:
> > > > Add a DT node example for ENETC v4 device.
> > >
> > > Not sure why need add examples here? Any big difference with existed
> > > example?
> > >
> >
> > For enetc v4, we have added clocks, and it also supports ptp-timer
> > property, these are different from enetc v1, so I think it is better to
> > add an example for v4.
> 
> If there are not big change, needn't duplicate one example at yaml file,
> the content should be in dts file already. Pass DTB_CHECK should be okay.

Two new properties is on the edge of justification of new example. I am
fine with both - having this patch and dropping it.

Best regards,
Krzysztof