netdev - Re: [PATCH 5/6] can: esd_usb: Rework display of error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250814-uncovered-debonair-porpoise-28f516-mkl@pengutronix.de>
Date: Thu, 14 Aug 2025 14:45:01 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Stefan Mätje <stefan.maetje@....eu>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	Frank Jungclaus <frank.jungclaus@....eu>, linux-can@...r.kernel.org, socketcan@....eu, 
	Simon Horman <horms@...nel.org>, Olivier Sobrie <olivier@...rie.be>, 
	Oliver Hartkopp <socketcan@...tkopp.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 5/6] can: esd_usb: Rework display of error messages

On 13.08.2025 10:12:03, Marc Kleine-Budde wrote:
> On 11.08.2025 23:06:10, Stefan Mätje wrote:
> > - esd_usb_open(): Get rid of duplicate "couldn't start device: %d\n"
> >   message already printed from esd_usb_start().
> > - Added the printout of error codes together with the error messages
> >   in esd_usb_close() and some in esd_usb_probe(). The additional error
> >   codes should lead to a better understanding what is really going
> >   wrong.
> > - Fix duplicate printout of network device name when network device
> >   is registered. Add an unregister message for the network device
> >   as counterpart to the register message.
> 
> If you want to print errors, please use '"%pE", ERR_PTR(err)', that will
> decode the error code into human readable form.

Sorry, I meant to say "%pe".

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)