netdev - Re: [PATCH 1/6] can: esd_usb: Fix possible calls to kfree() with NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e30abd4fe42b56158debde0caf71ebac89cc8cb.camel@esd.eu>
Date: Fri, 15 Aug 2025 14:57:44 +0000
From: Stefan Mätje <stefan.maetje@....eu>
To: "vadim.fedorenko@...ux.dev" <vadim.fedorenko@...ux.dev>,
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>, "mkl@...gutronix.de"
	<mkl@...gutronix.de>, Frank Jungclaus <frank.jungclaus@....eu>,
	"mailhol.vincent@...adoo.fr" <mailhol.vincent@...adoo.fr>, socketcan
	<socketcan@....eu>
CC: "horms@...nel.org" <horms@...nel.org>, "socketcan@...tkopp.net"
	<socketcan@...tkopp.net>, "olivier@...rie.be" <olivier@...rie.be>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/6] can: esd_usb: Fix possible calls to kfree() with NULL

Am Dienstag, dem 12.08.2025 um 13:33 +0100 schrieb Vadim Fedorenko:
> On 11/08/2025 22:06, Stefan MÃ¤tje wrote:
> > In esd_usb_start() kfree() is called with the msg variable even if the
> > allocation of *msg failed.
> 
> But kfree() works fine with NULL pointers, have you seen any real issues
> with this code?

Hello Vadim,

I've not seen real problems with this code. And when I posted the patch I
knew that kfree() can cope with NULL pointers. But in any case calling a
*free() function with a NULL pointer sends shivers over my spine and I
want to avoid to stumble over this again and again.

Best regards,
   Stefan