netdev - Re: [PATCH net-next] Check in_sack firstly in tcp_match_skb_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250815114505.2d65b80e@kernel.org>
Date: Fri, 15 Aug 2025 11:45:05 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Xin Guo <guoxin0309@...il.com>
Cc: ncardwell@...gle.com, edumazet@...gle.com, davem@...emloft.net,
 dsahern@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] Check in_sack firstly in
 tcp_match_skb_to_sack()

On Tue, 12 Aug 2025 23:23:22 +0800 Xin Guo wrote:
> This is because only when in_sack is equal to false
> the pkt_len can be greater than or equal to skb->len,
> so checking the in_sack firstly will make the logic
> more clear.

no acks/review tags seem to be forthcoming so not sure this 
is enough of an improvement to justify patching