netdev - Re: [PATCH] net: af_packet: Use hrtimer to do the retire operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250815025437.1053773-1-jackzxcui1989@163.com>
Date: Fri, 15 Aug 2025 10:54:37 +0800
From: Xin Zhao <jackzxcui1989@....com>
To: willemdebruijn.kernel@...il.com,
	edumazet@...gle.com,
	ferenc@...es.dev
Cc: davem@...emloft.net,
	kuba@...nel.org,
	pabeni@...hat.com,
	horms@...nel.org,
	netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: af_packet: Use hrtimer to do the retire operation

On Fri, 2025-08-15 at 1:29 +0800, Willem wrote:

> > -	p1->tov_in_jiffies = msecs_to_jiffies(p1->retire_blk_tov);
> > +	p1->tov_in_msecs = p1->retire_blk_tov;
> 
> Can probably drop this field as it's the same as retire_blk_tov.
> 
> Or convert to ktime_t next_timer, to be able to replace ktime_get()
> with ktime_add_ms when rearming when calling hrtimer_set_expires.

Dear Willem,

Thank you for your suggestion.
I will drop the tov_in_msecs field in PATCH v2.
Additionally, I think we cannot avoid using ktime_get, as the retire
timeout for each block is not fixed. When there are a lot of network packets,
a block can retire quickly, and if we do not re-fetch the time, the timeout
duration may be set incorrectly.

Thanks
Xin Zhao