netdev - Re: [PATCH] net: pcs-rzn1-miic: Correct MODCTRL register offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8v+b3qHL=64xnVPoG8M+7drieanw5wWRPZFSZe-XqOigw@mail.gmail.com>
Date: Mon, 18 Aug 2025 17:21:38 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Clément Léger <clement.leger@...tlin.com>, 
	Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Florian Fainelli <f.fainelli@...il.com>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, stable@...nel.org
Subject: Re: [PATCH] net: pcs-rzn1-miic: Correct MODCTRL register offset

Hi Andrew,

Thank you for the feedback.

On Mon, Aug 18, 2025 at 4:12 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Mon, Aug 18, 2025 at 04:07:57PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>
> Please set the Subject: correctly.
>
My bad, I'll take care of this in the next version.

> > Correct the Mode Control Register (MODCTRL) offset for RZ/N MIIC.
> > According to the R-IN Engine and Ethernet Peripherals Manual (Rev.1.30)
> > [0], Table 10.1 "Ethernet Accessory Register List", MODCTRL is at offset
> > 0x8, not 0x20 as previously defined.
>
> What effect does this have? How would i notice it is broken?
>
I will update the commit description.

Cheers,
Prabhakar