netdev - Re: [PATCH net-next v13 1/8] hinic3: Async Event Queue interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <715111b5-6cd1-45c0-b398-b5d8bec7f24f@redhat.com>
Date: Tue, 19 Aug 2025 15:22:01 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Fan Gong <gongfan1@...wei.com>, Zhu Yikai <zhuyikai1@...artners.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, linux-doc@...r.kernel.org,
 Jonathan Corbet <corbet@....net>, Bjorn Helgaas <helgaas@...nel.org>,
 luosifu <luosifu@...wei.com>, Xin Guo <guoxin09@...wei.com>,
 Shen Chenyang <shenchenyang1@...ilicon.com>,
 Zhou Shuai <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>,
 Shi Jing <shijing34@...wei.com>, Fu Guiming <fuguiming@...artners.com>,
 Meny Yossefi <meny.yossefi@...wei.com>, Gur Stavi <gur.stavi@...wei.com>,
 Lee Trager <lee@...ger.us>, Michael Ellerman <mpe@...erman.id.au>,
 Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Suman Ghosh
 <sumang@...vell.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Joe Damato <jdamato@...tly.com>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH net-next v13 1/8] hinic3: Async Event Queue interfaces

On 8/15/25 3:01 AM, Fan Gong wrote:
> +static void remove_eq(struct hinic3_eq *eq)
> +{
> +	hinic3_set_msix_state(eq->hwdev, eq->msix_entry_idx,
> +			      HINIC3_MSIX_DISABLE);
> +	free_irq(eq->irq_id, eq);
> +	/* Indirect access should set q_id first */
> +	hinic3_hwif_write_reg(eq->hwdev->hwif,
> +			      HINIC3_EQ_INDIR_IDX_ADDR(eq->type),
> +			      eq->q_id);
> +
> +	cancel_work_sync(&eq->aeq_work);

The above should be 'disable_work_sync()' to avoid the work being
re-scheduled by the flushed handler and later UaF.

/P