netdev - Re: [PATCH] net: openvswitch: Use for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b88c0fb-40de-41a4-9831-cb986bb6570e@ovn.org>
Date: Tue, 19 Aug 2025 15:23:11 +0200
From: Ilya Maximets <i.maximets@....org>
To: Yury Norov <yury.norov@...il.com>, Aaron Conole <aconole@...hat.com>,
 Eelco Chaudron <echaudro@...hat.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 dev@...nvswitch.org, linux-kernel@...r.kernel.org
Cc: i.maximets@....org
Subject: Re: [PATCH] net: openvswitch: Use for_each_cpu() where appropriate

On 8/18/25 7:28 PM, Yury Norov wrote:
> From: "Yury Norov (NVIDIA)" <yury.norov@...il.com>
> 
> Due to legacy reasons, openswitch code opencodes for_each_cpu() to make
> sure that CPU0 is always considered.
> 
> Since commit c4b2bf6b4a35 ("openvswitch: Optimize operations for OvS
> flow_stats."), the corresponding  flow->cpu_used_mask is initialized
> such that CPU0 is explicitly set.
> 
> So, switch the code to using plain for_each_cpu().
> 
> Suggested-by: Ilya Maximets <i.maximets@....org>
> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@...il.com>
> ---
>  net/openvswitch/flow.c       | 12 ++++--------
>  net/openvswitch/flow_table.c |  7 +++----
>  2 files changed, 7 insertions(+), 12 deletions(-)
> 
> v1: https://lore.kernel.org/all/20250814195838.388693-1-yury.norov@gmail.com/
> v2:
>  - always include CPU0 (Ilya);

nit: The subject prefix should've been [PATCH net-next v2].

The change itself looks correct to me.  Thanks!

Acked-by: Ilya Maximets <i.maximets@....org>