netdev - Re: [PATCH] selftests net/socket.c: removed warnings from unused returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+hkOd4T1rNymXV1C+kf78_Z+Bie59q_uMsMt_bOrvsPn3EqZQ@mail.gmail.com>
Date: Mon, 18 Aug 2025 19:27:53 -0700
From: Alex Tran <alex.t.tran@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	horms@...nel.org, shuah@...nel.org, netdev@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests net/socket.c: removed warnings from unused returns

Thanks for the review! I'll send the patch v2 with the adjustments shortly.

On Mon, Aug 18, 2025 at 5:35 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 14 Aug 2025 23:06:31 -0700 Alex Tran wrote:
> > +     char *err_message1;
> > +     char *err_message2;
>
> nit, how about:
>
>         const char *msg1, *msg2;
>
> ? And then please wrap the lines at 80 chars.
>
> >       int i, err;
> >
> >       err = 0;
> > @@ -56,13 +58,13 @@ static int run_tests(void)
> >                           errno == -s->expect)
> >                               continue;
> >
> > -                     strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
> > -                     strerror_r(errno, err_string2, ERR_STRING_SZ);
> > +                     err_message1 = strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
> > +                     err_message2 = strerror_r(errno, err_string2, ERR_STRING_SZ);



-- 
Alex Tran
alex.t.tran@...il.com | 408-406-2417