netdev - Re: [PATCH] selftests net/socket.c: removed warnings from unused returns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250818173515.1845a785@kernel.org>
Date: Mon, 18 Aug 2025 17:35:15 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Alex Tran <alex.t.tran@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 horms@...nel.org, shuah@...nel.org, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests net/socket.c: removed warnings from unused
 returns

On Thu, 14 Aug 2025 23:06:31 -0700 Alex Tran wrote:
> +	char *err_message1;
> +	char *err_message2;

nit, how about:

	const char *msg1, *msg2;

? And then please wrap the lines at 80 chars.

>  	int i, err;
>  
>  	err = 0;
> @@ -56,13 +58,13 @@ static int run_tests(void)
>  			    errno == -s->expect)
>  				continue;
>  
> -			strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
> -			strerror_r(errno, err_string2, ERR_STRING_SZ);
> +			err_message1 = strerror_r(-s->expect, err_string1, ERR_STRING_SZ);
> +			err_message2 = strerror_r(errno, err_string2, ERR_STRING_SZ);