netdev - Re: [PATCH v1 net-next 1/7] tcp: Remove sk_protocol test for tcp_twsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLmj7vFhONUPGqCDZinBXy=q6kdG2bXVvsc5KmtTveGBg@mail.gmail.com>
Date: Wed, 20 Aug 2025 23:50:56 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Neal Cardwell <ncardwell@...gle.com>, 
	David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 1/7] tcp: Remove sk_protocol test for tcp_twsk_unique().

On Wed, Aug 20, 2025 at 11:16 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
>
> From: "Kuniyuki Iwashima <kuniyu@...zon.com>

Oh well.

>
> Commit 383eed2de529 ("tcp: get rid of twsk_unique()") added
> sk->sk_protocol test in  __inet_check_established() and
> __inet6_check_established() to remove twsk_unique() and call
> tcp_twsk_unique() directly.
>
> DCCP has gone, and the condition is always true.
>
> Let's remove the sk_protocol test.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>

Please fix the From:  because Kuniyuki Iwashima <kuniyu@...zon.com> is
no longer a valid email address.