netdev - Re: [PATCH v1 net-next 3/7] tcp: Remove timewait_sock_ops.twsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJyTbBdCnM+NJ6TWmO50=fcunvZHBFWwOpmf2n1FCm9kg@mail.gmail.com>
Date: Wed, 20 Aug 2025 23:53:20 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Neal Cardwell <ncardwell@...gle.com>, 
	David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 3/7] tcp: Remove timewait_sock_ops.twsk_destructor().

On Wed, Aug 20, 2025 at 11:16 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
>
> From: Kuniyuki Iwashima <kuniyu@...zon.com>

Please fix ?

git commit --amend --author "Kuniyuki Iwashima <kuniyu@...gle.com>"

Other than that:

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

>
> Since DCCP has been removed, sk->sk_prot->twsk_prot->twsk_destructor
> is always tcp_twsk_destructor().
>
> Let's call tcp_twsk_destructor() directly in inet_twsk_free() and
> remove ->twsk_destructor().
>
> While at it, tcp_twsk_destructor() is un-exported.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>
> ---